[Perf] Reserve the exact capacity in ToBits for BigIntegers #2514
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <[email protected]>
joske
approved these changes
Jul 9, 2024
vicsn
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While heap-profiling the loading of the Canary ledger, I was surprised by the number of temporary allocations pointing to the
ToBitsimpl forBigInteger256; it appears that theExtendimpl that's used there is not able to take advantage of theExactSizeIteratorimpl forBitIteratorLE, and we need to be more explicit in order to avoid them.The results at height 330598 are as follows: